forked from ublue-os/aurora
-
Notifications
You must be signed in to change notification settings - Fork 0
chore: update from rechunk branch #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
renner0e
wants to merge
14
commits into
main
Choose a base branch
from
update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The legacy rechunker is basically unmaintained, this is a much safer option to reduce our (delta) image size. https://coreos.github.io/rpm-ostree/build-chunked-oci/ https://gitlab.com/fedora/bootc/base-images/-/blob/main/bootc-base-imagectl
enable when coreos/rpm-ostree#5545 fixed
We need a newer podman version than ubuntu 24.04 provides, homebrew is the most elegant solution. We need the layer annotations for the rpm-ostree rechunker so that updates are more efficient. workaround for: containers/podman#27796
The metadata from a prior built image is used to construct the new one so that the difference between them is minimized if possible.
Theoretically way more layers possible (I tested with 2000+) but you can't podman run the image anymore with 500+ I think the limit used to be 255, no longer the case with Kernel 6.15+. We want as much layers as we can get away with because it makes rechunking much more efficient. See: https://github.com/containers/storage/blob/83cf57466529353aced8f1803f2302698e0b5cb7/drivers/overlay/overlay.go#L56-L81
This reverts commit e9dd3f8. Seemingly random failures I saw on nvidia iamges, let's see if this is the root cause
should fix symptoms caused by tmpfiles not running directly after sysuers zirconium-dev/zirconium#86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all changes since last update from ublue-os/aurora + rechunker branch
need the debug symbols to maybe figure out why rechunking is failing on
https://github.com/get-aurora-dev/aurora-test/actions/runs/20587794595/job/59127284924